From 05d72563637e88825ff852d803621c567de47e34 Mon Sep 17 00:00:00 2001 From: Agando Date: Sat, 7 Nov 2026 19:03:38 +0100 Subject: fix(newos4): second review round — identity for every stock node, load dedup, sweep race, a11y MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Four models (kimi-k2.7-code, deepseek-v4-pro, minimax-m3, glm-5.3) reviewed the shipped change set. Review log with every accepted and rejected finding: .hermes/plans/2026-11-07_163420-newos4-six-ui-modes.review-log.md - identity guard now covers every snapshot node, not just #terminal-container: terminal.js also binds #output, #command-input, #input-area and #status-bar, so a cloned one leaves the terminal writing into a detached node while the page looks perfect - _restoreStock anchors on the next stock node already home, then on the recorded trailing sibling; a raw child index was measured wrong (terminal,input,status-bar,quick-actions) - _loading map: a double-clicked card or a repeated 'ui easy' loads the mode once - _sweepPending returns while that id is in flight instead of declaring failure at 6 s and overwriting the stored preference - _syncChrome() on every switch (quick-actions was left in the tab order behind the mode root) - picker: role=dialog/aria-modal/labelledby/focus, shown after 600 ms instead of waiting for a registration that never happens with lazy modes, and suppressed when ?ui= already applied - ?ui= must be one of the six; _loadMode only accepts packages['ui-']; hasOwnProperty on modes - VFS names are shell-quoted before reaching api.exec (cat/edit) - refresh generation no longer bumps per tick (slow captures left later panes at '...') - easy: padding shorthand reset the 34 px footer reserve (footer overlapped the composer) - cockpit panes get tabIndex and focus; F1/F12 left to the browser; nothing swallowed in inputs - api.el lost its unused innerHTML sink; the test lost its _parseArgs stub (it hid the regression) - v4.6.155 --- modules/ext/ui-workspace.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'modules/ext/ui-workspace.js') diff --git a/modules/ext/ui-workspace.js b/modules/ext/ui-workspace.js index be7a5e0..ee20aac 100644 --- a/modules/ext/ui-workspace.js +++ b/modules/ext/ui-workspace.js @@ -107,7 +107,10 @@ body[data-ui-mode="workspace"] #ui-root { display: flex; flex-direction: column; // a detached tree (invisible work, retained DOM). Every refresh claims a generation. let gen = 0; const refresh = async () => { - const my = ++gen; + // Do NOT bump the generation on every tick: a capture slower than the 15 s interval + // invalidated the in-flight run before it reached the later cards, so those stayed at + // "…" forever under slow storage (found by review). Teardown still bumps gen to stop it. + const my = gen; let changed = 0; for (const c of cards) { try { -- cgit v1.2.3