From 8d5c4b563da5225c4dbd2a44c7635c49a16d5ab1 Mon Sep 17 00:00:00 2001 From: Agando Date: Mon, 2 Nov 2026 20:46:18 +0100 Subject: feat(newos4): configurable tool budgets, per-model defaults, real tool telemetry Closes STEER-20261102-201234-7200 (read_file capped at 6000 while the schema promised 32000). Budgets (module-aiassist.js + new modules/core/model-profiles.js): - one resolver, precedence: call arg -> loop profile -> model profile -> ai-config -> code default. Keys: read-page-chars, read-result-chars, tool-context-budget, fetch-chars. - model classes tiny/small/mid/large keyed by id then by size token; `mid` reproduces the old numbers so nothing moves for a mid model. - _clipToolResult now clips the `content` field, never the serialised JSON envelope: clipping the envelope deleted truncated/next_offset, so a 16k page lost its continuation pointer (the reported symptom). - read_file's schema no longer promises a number the model class may not give. Telemetry: - _recordToolCall keeps sizes, duration, ok and a 120-char arg preview instead of the whole payload; ai-stats prints calls / ok% / avg ms / KB / truncation from localStorage webx11_tool_stats. Server (api/proxy-api.py): - /api/extract honours max_chars (default 12000, cap 100000) and returns content_chars + truncated; the bs4 branch is no longer uncapped while the regex fallback was silently cut at 10 000. BEHAVIOUR CHANGE: num_ctx for a model with no explicit setting now follows the class default (16384 -> 65536 for cloud/large, 8192 for tiny). Cloud models bill on tokens used, so cost is unchanged; local models get a bigger KV cache. Two build traps, both now documented in AGENTS.md: - model-profiles.js must be the FIRST entry in CORE_FILES and must export the MODEL_PROFILES global (a TDZ typeof throws; without the global every budget silently falls back to the code default). - a budget key needs the setter branch AND the constructor loader at module-aiassist.js:49 - persisting without restoring looks fine until reload. Verified: test-tool-context-bound 23/23 (RED before: E1-E4 + TypeError on _toolLimit); live bundle read_page 32000 / result 12000 / budget 48000 / fetch 12000 and _ctxTokens 65536 for gemma4:31b-cloud; /api/extract 28970 -> 500 chars with truncated true; ai-config write+restore probe 6/6. --- scripts/rebuild-bundles.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'scripts/rebuild-bundles.py') diff --git a/scripts/rebuild-bundles.py b/scripts/rebuild-bundles.py index a231e32..7f82817 100644 --- a/scripts/rebuild-bundles.py +++ b/scripts/rebuild-bundles.py @@ -8,6 +8,8 @@ import os ROOT = '/var/www/webx11.duckdns.org/spaces/newos4' CORE_FILES = [ + # First: a top-level `const` later in the bundle is in TDZ for `typeof MODEL_PROFILES`. + 'model-profiles.js', 'virtual-fs.js', 'module-manager.js', 'ollama-manager.js', -- cgit v1.2.3