aboutsummaryrefslogtreecommitdiff
path: root/modules/core/core-bundle.js
diff options
context:
space:
mode:
authorAgando <roduccomm@gmail.com>2026-11-02 21:15:28 +0100
committerAgando <roduccomm@gmail.com>2026-11-02 21:15:28 +0100
commit3b894c31c456592a21b36a7696423ad0936edab7 (patch)
tree3f23f9a313d351dff0740de90aef56a9cca4d8f9 /modules/core/core-bundle.js
parent35ca5324ca5a0b3e1e6f02663e1e44d6e06e50ba (diff)
fix(newos4): memory-graph loads stop rewriting user data; unknown sizes say unknown
Three follow-ups from the merge review, each with the assertion that pins it. module-memory-graph.js - _normalizeEdges no longer mutates stored weights. It capped legacy 'failed' edges from 0.8 to 0.2 in memory, and the next debounced save made that permanent - an irreversible migration of the user's graph with no schema version. The cap moved to _effectiveWeight(), which ranking (showStats "Strongest relationships"), the session view and prune() now use; the stored record is left exactly as written. - config.json is stamped version: 2 so a future format change can migrate deliberately. ext/webdav.js - the two fallback parsers emit size: null instead of 0. They cannot see the size column, and 0 rendered as "0 B" - the same "every file looks empty" symptom as the parseInt bug fixed in e639c2d, one regex miss away. - _formatSize(null) renders '—' (unknown) rather than '0 B'; 0 still renders '0 B'. module-aiassist.js - the lock timeout now says what to do: "AI is still busy with another turn (waited Ns). Wait for it to finish, or run 'ai-stop' and retry - the running turn's lock is left alone." It used to be a dead-end string. Tests: test-memory-graph 39 (T6.4 rewritten to the read-time contract: stored weight stays 0.8, effective 0.2, success unaffected), test-webdav-sizes 28 (A14d null -> '—'). maintain 26/26, live v4.6.141: _effectiveWeight 0.2 with the edge object unchanged, _formatSize(null) '—', '0 B' still '0 B'.
Diffstat (limited to 'modules/core/core-bundle.js')
-rw-r--r--modules/core/core-bundle.js36
1 files changed, 26 insertions, 10 deletions
diff --git a/modules/core/core-bundle.js b/modules/core/core-bundle.js
index 379c297..71f3ada 100644
--- a/modules/core/core-bundle.js
+++ b/modules/core/core-bundle.js
@@ -9708,8 +9708,9 @@ max_chars: { type: 'integer', description: 'Max characters of page content to re
const lockStart = Date.now();
while (!_agentTag && this._chatLock) {
if (Date.now() - lockStart > this._chatLockTimeoutMs) {
- throw new Error("chat lock busy after " + Math.round(this._chatLockTimeoutMs / 1000)
- + "s — refusing to release another turn's lock");
+ throw new Error("AI is still busy with another turn (waited "
+ + Math.round(this._chatLockTimeoutMs / 1000)
+ + "s). Wait for it to finish, or run 'ai-stop' and retry — the running turn's lock is left alone.");
}
await new Promise(r => setTimeout(r, 50));
}
@@ -18537,7 +18538,7 @@ class MemoryGraphModule {
for (const e of edges.slice(0, 3)) {
const other = e.source === n.id ? e.target : e.source;
const otherLabel = (this._nodes[other] || {}).label || other;
- this.terminal.print(` └─ ${e.type} → ${otherLabel} (w:${e.weight.toFixed(1)})`, 'text-muted');
+ this.terminal.print(` └─ ${e.type} → ${otherLabel} (w:${this._effectiveWeight(e).toFixed(1)})`, 'text-muted');
}
}
if (results.length > 20) this.terminal.print(` ... and ${results.length - 20} more`, 'info');
@@ -18566,13 +18567,13 @@ class MemoryGraphModule {
}
// Strongest edges
- const strong = [...this._edges].sort((a, b) => b.weight - a.weight).slice(0, 3);
+ const strong = [...this._edges].sort((a, b) => this._effectiveWeight(b) - this._effectiveWeight(a)).slice(0, 3);
if (strong.length > 0) {
this.terminal.print(' Strongest relationships:', 'info');
for (const e of strong) {
const sLabel = (this._nodes[e.source] || {}).label || e.source;
const tLabel = (this._nodes[e.target] || {}).label || e.target;
- this.terminal.print(` ${sLabel} → ${tLabel} (${e.type}, w:${e.weight.toFixed(2)}, used ${e.use_count}x)`, 'info');
+ this.terminal.print(` ${sLabel} → ${tLabel} (${e.type}, w:${this._effectiveWeight(e).toFixed(2)}, used ${e.use_count}x)`, 'info');
}
}
@@ -18617,7 +18618,7 @@ class MemoryGraphModule {
if (age < THIRTY_DAYS) return true;
if (e.use_count >= 3) return true;
// Or if weight is high
- if (e.weight > 0.8) return true;
+ if (this._effectiveWeight(e) > 0.8) return true;
return false;
});
const pruned = before - this._edges.length;
@@ -18901,15 +18902,29 @@ class MemoryGraphModule {
// successes — so a stored graph would keep ranking failures on top until they were re-seen.
// Nothing else is rewritten: weights, ids and timestamps are otherwise left exactly as stored,
// so old Date.now() task ids stay addressable (they simply coexist with new hashed ids).
+ // Compatibility shim for stores written before the weight rules changed. It is
+ // deliberately NON-DESTRUCTIVE: a load must not rewrite what the next save persists.
+ // Anything that needs the corrected value (ranking, pruning, display) asks
+ // _effectiveWeight(), so a legacy 0.8 'failed' edge stops outranking successes without
+ // the stored record being altered.
_normalizeEdges() {
for (const e of this._edges) {
- if (!e.source_agents) e.source_agents = [];
- const w = Number(e.weight);
- e.weight = Number.isFinite(w) ? w : 0.5;
- if (e.type === 'failed' && e.weight > 0.2) e.weight = 0.2;
+ if (!Array.isArray(e.source_agents)) e.source_agents = [];
+ if (!Number.isFinite(Number(e.weight))) e.weight = 0.5;
}
}
+ // The weight an edge is ranked/pruned by. Legacy stores wrote failures at 0.8 (above the
+ // 0.5 success weight, which put them at the top of "Strongest relationships"); the cap
+ // lives here instead of in the stored data.
+ _effectiveWeight(e) {
+ if (!e) return 0;
+ const w = Number(e.weight);
+ if (!Number.isFinite(w)) return 0;
+ if (e.type === 'failed' && w > 0.2) return 0.2;
+ return w;
+ }
+
// MAINT-003: keep an unreadable store aside instead of starting fresh over it.
_quarantineCorrupt(name) {
try {
@@ -18940,6 +18955,7 @@ class MemoryGraphModule {
fs.fsWriteJSON(`${this._indexPath}edges.json`, this._edges);
// v4.5.89b fix: Persist decay config (P1 from review)
fs.fsWriteJSON(`${this._indexPath}config.json`, {
+ version: 2, // format stamp: weight semantics changed in v4.6.140
decayDays: this._decayDays,
decayMinUses: this._decayMinUses,
lastDecayRun: this._lastDecayRun