diff options
| author | Agando <roduccomm@gmail.com> | 2026-10-23 20:59:29 +0200 |
|---|---|---|
| committer | Agando <roduccomm@gmail.com> | 2026-10-23 20:59:29 +0200 |
| commit | bc99dfba1898123ea824de98a2d5a06e996ed667 (patch) | |
| tree | ad9927db7f3504e2e02c2a9e600fdf533f898c89 /modules/core/module-orchestrator.js | |
| parent | b93cd918e967c147b6169fa5bb89241bd7488525 (diff) | |
fix(newos4): outboxResult scoped, markdown mime, old reply path retired (v4.6.81)
delegateTask declared `const outboxResult` inside the AI branch and returned it outside, so a
delegation with the AI module missing threw 'outboxResult is not defined'. The catch turned that
into _handleAgentFailure: the worker stayed idle with no result while spawn_agent reported ok —
the reported symptom exactly. Now function-scoped, and the no-module path returns
'queued — AI module not loaded, nothing executed' rather than claiming 'completed'.
Also: nginx served _docs/*.md as application/octet-stream (no .md type) — now text/markdown +
nosniff; agent-replies.php returns 410 for GET as well as POST, so there is one reply path.
Verified: with the AI module deleted at runtime, delegateTask returns the queued string and
throws nothing.
Diffstat (limited to 'modules/core/module-orchestrator.js')
| -rw-r--r-- | modules/core/module-orchestrator.js | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/modules/core/module-orchestrator.js b/modules/core/module-orchestrator.js index b3b76cd..5e03b0b 100644 --- a/modules/core/module-orchestrator.js +++ b/modules/core/module-orchestrator.js @@ -1153,6 +1153,10 @@ class OrchestratorModule { // Single sub-task — fall through to normal path } + // Declared in function scope: the AI branch assigns it, but the return at the end of + // this method runs even when that branch never did. + let outboxResult = null; + // Find an idle agent and immediately stamp it busy (atomic claim) let agent = Object.values(this._agents).find(a => a.status === 'idle'); if (agent) { @@ -1241,7 +1245,7 @@ class OrchestratorModule { this.terminal.print(`✅ ${agent.id} completed task`, 'success'); // Return result for callers that await delegateTask - const outboxResult = typeof result === 'string' ? result : (result?.content || 'completed'); + outboxResult = typeof result === 'string' ? result : (result?.content || 'completed'); // Check restart policy — if always, set back to idle for next task if (agent.restartPolicy === 'always') { @@ -1252,6 +1256,7 @@ class OrchestratorModule { } } else { this.terminal.print(`ℹ️ AI module not available — task queued for ${agent.id}`, 'info'); + outboxResult = 'queued — AI module not loaded, nothing executed'; } } catch (e) { this._handleAgentFailure(agent.id, e.message); @@ -1267,7 +1272,7 @@ class OrchestratorModule { agent.status = 'idle'; agent.lastHeartbeat = Date.now(); } - return outboxResult || 'completed'; + return outboxResult || 'no result recorded'; } // ─── Recurring Scheduling ─── |