fix(newos4): define VirtualFS.emptyTrash() — empty-trash threw since 2026-10-18

Report RPT-20261018-164646-89352963 ("this.fs.emptyTrash is not a function") was filed by the auto-filer and never fixed: terminal.js:1777 called a method VirtualFS never defined, so 'empty-trash --confirm' threw instead of emptying. Added emptyTrash() returning true only when it removed something.

Verified live on v4.6.54: put -> rm -> empty-trash --confirm => 'Trash emptied.'; second run => 'Trash is already empty.'; .trash entries 0.

1 files changed, 27 insertions, 0 deletions

diff --git a/modules/core/virtual-fs.js b/modules/core/virtual-fs.js
index 8f11d25..c9eb7a3 100644
--- a/modules/core/virtual-fs.js
+++ b/modules/core/virtual-fs.js
@@ -595,6 +595,7 @@ class VirtualFileSystem {
             const trash = this.root.content['.trash'];
             const trashName = ts + '-' + name;
             trash.content[trashName] = JSON.parse(JSON.stringify(node));
+            this._pruneTrash();
             const resolved = this._resolvePath(path);
             if (resolved) delete resolved.dir.content[resolved.name];
             this.saveToStorage();
@@ -620,6 +621,7 @@ class VirtualFileSystem {
                 let ctr = 0;
                 while (trash.content[unique]) { unique = baseName + '-' + (++ctr); }
                 trash.content[unique] = JSON.parse(JSON.stringify(node));
+                this._pruneTrash();
                 delete resolved.dir.content[resolved.name];
                 this.saveToStorage();
                 this._emitChange(path);
@@ -628,6 +630,31 @@ class VirtualFileSystem {
         }
         return false;
     }
+    // Reported 2026-10-18 ("this.fs.emptyTrash is not a function") and verified 2026-10-23:
+    // terminal.js:1777 called this method but nothing ever defined it, so `empty-trash --confirm`
+    // threw instead of emptying. Returns true only when something was actually removed.
+    emptyTrash() {
+        const trash = this.root.content && this.root.content['.trash'];
+        if (!trash || !trash.content) return false;
+        const names = Object.keys(trash.content);
+        if (!names.length) return false;
+        names.forEach(n => { delete trash.content[n]; });
+        this.saveToStorage();
+        this._emitChange('/.trash');
+        return true;
+    }
+    _pruneTrash(maxEntries = 50) {
+        // Bounded trash: deletions are moves-to-trash, so without a cap / .trash/ was an
+        // unbounded second accumulator. Names start with a millis timestamp → sort = oldest first.
+        const trash = this.root.content['.trash'];
+        if (!trash) return 0;
+        const keys = Object.keys(trash.content);
+        if (keys.length <= maxEntries) return 0;
+        keys.sort();
+        const drop = keys.slice(0, keys.length - maxEntries);
+        drop.forEach(k => { delete trash.content[k]; });
+        return drop.length;
+    }
     deleteDirRecursive(path) {
         return this.trashDir(path);
     }