fix(newos4): second review round — identity for every stock node, load dedup, sweep race, a11y

Four models (kimi-k2.7-code, deepseek-v4-pro, minimax-m3, glm-5.3) reviewed the shipped change
set. Review log with every accepted and rejected finding:
.hermes/plans/2026-11-07_163420-newos4-six-ui-modes.review-log.md

- identity guard now covers every snapshot node, not just #terminal-container: terminal.js also
  binds #output, #command-input, #input-area and #status-bar, so a cloned one leaves the terminal
  writing into a detached node while the page looks perfect
- _restoreStock anchors on the next stock node already home, then on the recorded trailing
  sibling; a raw child index was measured wrong (terminal,input,status-bar,quick-actions)
- _loading map: a double-clicked card or a repeated 'ui easy' loads the mode once
- _sweepPending returns while that id is in flight instead of declaring failure at 6 s and
  overwriting the stored preference
- _syncChrome() on every switch (quick-actions was left in the tab order behind the mode root)
- picker: role=dialog/aria-modal/labelledby/focus, shown after 600 ms instead of waiting for a
  registration that never happens with lazy modes, and suppressed when ?ui= already applied
- ?ui= must be one of the six; _loadMode only accepts packages['ui-<id>']; hasOwnProperty on modes
- VFS names are shell-quoted before reaching api.exec (cat/edit)
- refresh generation no longer bumps per tick (slow captures left later panes at '...')
- easy: padding shorthand reset the 34 px footer reserve (footer overlapped the composer)
- cockpit panes get tabIndex and focus; F1/F12 left to the browser; nothing swallowed in inputs
- api.el lost its unused innerHTML sink; the test lost its _parseArgs stub (it hid the regression)
- v4.6.155

1 files changed, 5 insertions, 1 deletions

diff --git a/modules/ext/ui-cockpit.js b/modules/ext/ui-cockpit.js
index 92dd60b..73fbe9f 100644
--- a/modules/ext/ui-cockpit.js
+++ b/modules/ext/ui-cockpit.js
@@ -62,6 +62,7 @@ body[data-ui-mode="cockpit"] #ui-root { display: grid; grid-template-rows: 1fr 1
         defs.forEach((d, i) => {
             const pane = api.el('div', { class: 'pane' });
             pane.dataset.pane = String(i + 1);
+            pane.tabIndex = -1;                 // so F1-F8 can actually move focus, not just scroll
             const h = api.el('h5');
             h.appendChild(api.el('span', { text: 'F' + (i + 1) + ' ' + d.label }));
             h.appendChild(api.el('span', { class: 'n' }));
@@ -85,7 +86,9 @@ body[data-ui-mode="cockpit"] #ui-root { display: grid; grid-template-rows: 1fr 1
         // Generation guard: eight async captures per tick at 5s — a tick can outlive teardown.
         let gen = 0;
         const refresh = async () => {
-            const my = ++gen;
+            // Same as workspace: bumping per tick cancelled a slow run before the later panes were
+            // written, leaving them at "…" indefinitely.
+            const my = gen;
             for (const d of defs) {
                 try {
                     const text = await api.capture(d.cmd);
@@ -117,6 +120,7 @@ body[data-ui-mode="cockpit"] #ui-root { display: grid; grid-template-rows: 1fr 1
             if (idx === 5) { refresh(); return; }              // F5 = refresh, as labelled
             const pane = panes.querySelector('[data-pane="' + idx + '"]');
             if (!pane) return;
+            if (pane.focus) pane.focus();
             pane.scrollIntoView({ block: 'nearest' });
             pane.style.outline = '1px solid var(--accent-color)';
             setTimeout(() => { pane.style.outline = ''; }, 900);