diff options
| author | Agando <roduccomm@gmail.com> | 2026-10-23 17:46:41 +0200 |
|---|---|---|
| committer | Agando <roduccomm@gmail.com> | 2026-10-23 17:46:41 +0200 |
| commit | 83e64b88910c952c7469cee57cc5c5a8a07ad902 (patch) | |
| tree | ddcbc0253fe26b5cc016da2a2acc58f2e5359dfa /modules/test/test-predictor-accuracy.js | |
| parent | 895d8f5ed57c76f25770f88f290e6ab93949b6f8 (diff) | |
fix(newos4): predictor arithmetic, deployed-source viewer, ls text output (v4.6.57)
Acting on the "Request to the newOS4 team" packet (spaces/agando/guides/,
re-verified by its author on 4.6.56). Three verified defects fixed:
Packet 5 (predictor arithmetic) - module-predictor.js
- the persisted field named mape held a SUM while predictor-status divided by the
paired count: renamed to errorSum, older payloads read through
- errorPct is stored raw; the 500% clamp is now render-only, so a 475x miss stays
visible instead of being flattened to the ceiling
- predictions are floored at 1 s and marked floored; a floored prediction is
consumed but never scored as 100% error (a 0 s prediction is not a prediction)
- observations shorter than 1.5 s (aborted/instant runs) are marked unusable and
no longer train _findSimilar - one 0.079 s run was rounding the next prediction
to 0 s
- status prints an unpaired and an unscored count alongside the mean
Packet 10 (verification cannot see its own fixes) - module-aiassist.js
- view_module now returns the DEPLOYED source, prefixed with file and version,
and only falls back to the _mods copy with a "may be stale" banner. The
unversioned _mods/<Class>.js edit cache used to shadow the deployed file
forever, so the viewer showed pre-fix code while the bundle was new.
Proven by seeding a stale _mods/PredictorModule.js and calling the tool.
Packet 1b (ls exits clean with no output) - module-fs.js
- ls rendered only via printClickable(), which writes straight to the DOM, so any
capture (AI run_command, diagnostics) saw an empty result and reported "empty
directory". It now always prints a text line and keeps the clickable chips when
nothing is capturing.
Test: modules/test/test-predictor-accuracy.js 34/34 (new cases Q, R, S).
Diffstat (limited to 'modules/test/test-predictor-accuracy.js')
| -rw-r--r-- | modules/test/test-predictor-accuracy.js | 44 |
1 files changed, 43 insertions, 1 deletions
diff --git a/modules/test/test-predictor-accuracy.js b/modules/test/test-predictor-accuracy.js index 1a79167..3688b03 100644 --- a/modules/test/test-predictor-accuracy.js +++ b/modules/test/test-predictor-accuracy.js @@ -149,7 +149,7 @@ function ok(name, cond, detail) { p.notePrediction('read the logs', 'test'); p.recordResult(p._extractFeatures('read the logs'), 0.5, 1, true, { task: 'read the logs' }); const rec = p._dataPoints[p._dataPoints.length - 1]; - ok('K1 errorPct capped at 500%', rec.errorPct <= 5, 'errorPct=' + rec.errorPct); + ok('K1 errorPct is stored raw', rec.errorPct > 5, 'errorPct=' + rec.errorPct); } // L. a tool/loop prediction is never consumed by the similarity fallback @@ -205,5 +205,47 @@ function ok(name, cond, detail) { 'total=' + p._accuracy.total + ' pending=' + p._pending.length); } + +// Q. an aborted 0.079 s run must not drive the next prediction to zero (§5 point 1→2) +{ + const { p } = mk(); + const task = 'paste a 2158 char status report'; + p.notePrediction(task, 'loop'); + p.recordResult(p._extractFeatures(task), 0.079, 1, true, { task }); + const next = p.notePrediction(task, 'loop'); + ok('Q1 prediction is never 0 s', next.predictedDuration >= 1, 'pred=' + next.predictedDuration); + ok('Q2 the aborted run is marked unusable', p._dataPoints[0].usable === false); + ok('Q3 it never trains _findSimilar', p._findSimilar(p._extractFeatures(task)).length === 0); +} + +// R. the persisted field is a SUM and the display divides by the paired count +{ + const { p, out, term } = mk(true); + for (let i = 0; i < 2; i++) { + const task = 'read the logs'; + p.notePrediction(task, 'loop'); + p.recordResult(p._extractFeatures(task), 20, 2, true, { task }); // 15 s predicted vs 20 s observed + } + p._saveNow(); + const blob = JSON.parse(term.fs.readFile('/system/metrics/predictor.json')); + ok('R1 stored accumulator is a sum and is named errorSum', typeof blob.errorSum === 'number' && !('mape' in blob), + JSON.stringify(Object.keys(blob))); + out.length = 0; p.showStatus(); + const line = out.find(l => l.includes('Accuracy')) || ''; + ok('R2 display shows the mean with its sample count', /Accuracy: \d+% \(2\/2 paired\) · mean error \d+%/.test(line), line.trim()); +} + +// S. a floored prediction is consumed but not scored as error (§5 defect C) +{ + const { p } = mk(); + const pred = p.notePrediction('read the logs', 'test'); + p._pending[0].floored = true; + p._pending[0].predictedDuration = 1; + p.recordResult(p._extractFeatures('read the logs'), 54.7, 2, true, { task: 'read the logs' }); + ok('S1 floored prediction does not enter accuracy', p._accuracy.total === 0, 'total=' + p._accuracy.total); + ok('S2 it is still recorded and marked unscored', p._dataPoints[0].scored === false); + ok('S3 pending consumed', p._pending.length === 0); +} + console.log(passes + '/' + (passes + fails) + ' PASS'); process.exit(fails ? 1 : 0); |